Fix other options are forbidden when --no-source-map #59
Conversation
There was a problem hiding this comment.
OK, this looks good to me technically.
But won't it cause "WTH" problems when users will see those options in the bundle's configuration but they will be silently ignored? I mean, won't it be better to let the Sass binary throw an error so you could adjust bundle's config instead?
I laterally mean doing something like this in config:
symfonycasts_sass:
sass_options:
source_map: false
embed_sources: false
embed_source_map: falseThis config should solve the problem, right?
|
Lol, ok, now I see myself. The problem is that you get that So, IMO their (Sass) check isn't ideal as it should allow Anyway, how about mentioning this in the docs then? :) probably a comment over the
|
|
I wanted to suggest a change on their side... but it's implemented in that way since .... a long time. This is a quick fix. What i'd like to do next is use the "enable" symfony config option. So you'd have something like this symfonycasts_sass:
sass_options:
# Nothing
source-map: false
# Source map ON (no embed source)
source-map: true
# Source map ON and embed source
source-map:
embed-sources: true
# Source map OFF (and nothing else)
source-map:
enabled: false
embed-sources: false
# etc etc But really i'd release this fix now as it forbid people to compile their sass file in PROD env :( |
Yeah, not a big deal to just work it around I think 👍 Thank you for this quick fix!
That sounds like an interesting idea that would make things clearer... but it would also lead to a BC break in the configuration, though we could probably overcome it with some code complications. |
Fixes #58
Related Dart source code: https://github.com/sass/dart-sass/blob/006baa5642e6c0ff8bb41da8f914359e06fc04d4/lib/src/executable/options.dart#L440